[libvirt] [PATCH] split out logfile opening

Guido Günther agx at sigxcpu.org
Sat Jan 10 19:34:53 UTC 2009


On Fri, Jan 09, 2009 at 10:05:06AM +0100, Guido Günther wrote:
> On Tue, Jan 06, 2009 at 04:42:15PM +0100, Jim Meyering wrote:
> [..snip..] 
> > Thanks!
> > IMHO, committing your patch as-is, and then making the
> > suggested change in a separate change set would be fine.
> > Maybe even a little better, since it's easier to see
> > what's happening when one doesn't mix code-movement
> > changes with "real" changes.
> Does the attached patch look ok? I'll apply this together with
> 0001-split-out-opening-of-the-domain-logfile.patch then.
>  -- Guido
Rereading your mail you also suggest using sizeof() instead of PATH_MAX.
Updated patch attached.
 -- Guido
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-use-snprintf.patch
Type: text/x-diff
Size: 1567 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20090110/92d1da71/attachment-0001.bin>


More information about the libvir-list mailing list