[libvirt] [PATCH] don't raise a missing network as an internal error
Daniel P. Berrange
berrange at redhat.com
Tue Jul 7 14:16:43 UTC 2009
On Tue, Jul 07, 2009 at 04:06:03PM +0200, Daniel Veillard wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=509189
>
> When defining a domain referencing a missing network the erro should
> not be raised as an internal error. Patch by Paolo Bonzini looks fine to
> me,
ACK, though I get the feeling you could probably remove the qemudReportError
call there completely. IIRC, virNetworkLookupByName should have already
raised a suitable error message which we probably don't need to override.
Daniel
> diff --git a/src/qemu_conf.c b/src/qemu_conf.c
> index 9ca60b9..11eacb3 100644
> --- a/src/qemu_conf.c
> +++ b/src/qemu_conf.c
> @@ -716,8 +716,8 @@ qemudNetworkIfaceConnect(virConnectPtr conn,
> virNetworkPtr network = virNetworkLookupByName(conn,
> net->data.network.name);
> if (!network) {
> - qemudReportError(conn, NULL, NULL, VIR_ERR_INTERNAL_ERROR,
> - _("Network '%s' not found"),
> + qemudReportError(conn, NULL, NULL, VIR_ERR_NO_NETWORK,
> + _("Network '%s' not defined"),
> net->data.network.name);
> goto error;
> }
> --
> Libvir-list mailing list
> Libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list