[libvirt] [PATCH] use gnulib via a submodule

Daniel P. Berrange berrange at redhat.com
Wed Jul 8 11:16:36 UTC 2009


On Tue, Jul 07, 2009 at 07:02:08PM +0200, Jim Meyering wrote:
> @@ -5,7 +5,8 @@ AC_CONFIG_SRCDIR([src/libvirt.c])
>  AC_CONFIG_AUX_DIR([build-aux])
>  AM_CONFIG_HEADER([config.h])
>  dnl Make automake keep quiet about wildcards & other GNUmake-isms
> -AM_INIT_AUTOMAKE([-Wno-portability])
> +AM_INIT_AUTOMAKE([1.11 color-tests parallel-tests -Wno-portability])
> +AM_SILENT_RULES([yes]) # make --enable-silent-rules the default.
>  AC_CANONICAL_HOST

Actually an alternative idea - don't add a hard pre-requisite on 1.11.
Instead just add a

   m4_ifndef([AM_SILENT_RULES], [m4_define([AM_SILENT_RULES],[])])

ie, just provide a no-op AM_SILENT_RULES for older automake. Then we
can just throw out 'mylibtool'. People with new enough automake will
get the silent build support, and we can still have compatability with
older automake for RHEL-5 albeit without silent build support.


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the libvir-list mailing list