[libvirt] Re: [PATCH] build: do not emit a trailing blank line into VC'd file, NEWS

[Cole Robinson]

Jim Meyering wrote:
> Cole Robinson noticed that the generated NEWS file
> would fail the "make syntax-check" tests.
> This adjusts the rule that generates it not to emit
> any of the offending trailing blank lines.
> 
> At the same time, it regenerates NEWS.
> 
> From 53af8d848d78bcc5144b2c06b2109bbdc65803cf Mon Sep 17 00:00:00 2001
> From: Jim Meyering <meyering at redhat.com>
> Date: Thu, 16 Jul 2009 22:46:43 +0200
> Subject: [PATCH] build: do not emit a trailing blank line into VC'd file, NEWS
> 
> * docs/Makefile.am ($(top_builddir)/NEWS): Adjust rule to filter
> out any trailing blank lines when generating this file.
> * NEWS: Regenerate.
> ---
>  NEWS             |   56 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  docs/Makefile.am |    7 ++++-
>  2 files changed, 61 insertions(+), 2 deletions(-)
> 
> diff --git a/NEWS b/NEWS
> index 5733fa8..447d2b4 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -5,6 +5,62 @@
>         http://libvirt.org/news.html
> 
> 
> +0.6.5: Jul  3 2009:
> +   - New features: create storage columes on disk backend (Henrik Persson),
> +          drop of capabilities based on libcap-ng when possible (Daniel
> +          Berrange)
> +   - Portability: fix build on non-Linux targets (Daniel Berrange)
> +   - Documentation: typo and english fixes (Runa Bhattacharjee and
> +          Garry Dolley), Docs on extending APIs (Dave Allan), cleanup
> +          of debug and logging documentation (Amy Griffis), add
> +          HACKING doc to the website (Daniel Berrange),
> +          documentation for OpenNebula driver (Abel Miguez Rodriguez)
> +   - Bug fixes: forbid autostart on transcient networks,
> +          xen device removal crash (Daniel Berrange), re-detection of
> +          transient VMs after libvirtd restart(Daniel Berrange),
> +          bug in virFindFileInPath (Daniel Berrange), handle new
> +          availheap sysctl in Xen (Daniel Berrange), allow USB hostdev
> +          product 0 (Cole Robinson), cleanup when creating a storage pool
> +          fails (Henrik Persson), domain id fix on redefinition in
> +          test driver (Cole Robinson), fix raw storage allocation (Cole
> +          Robinson), memory reporting for inactive qemu drivers (Cole
> +          Robinson), segfault if storage pool has no type attribute (Cole
> +          Robinson), OpenNebula compilation issues (Javier Fontan),
> +          dominfo command without security driver (Daniel Berrange),
> +          domain state problems after migration or destroy (Federico
> +          Simoncelli), leak in node device parsing (Dave Allan),
> +          storage pool definitions reading at startup (Cole Robinson),
> +          bogus WWN in NPIV support (David Allan), avoid a segfault with
> +          recent Xen (Sascha), cope with libnuma failures on weird
> +          topologies (Dan Berrange), crash in QEMU driver with bad capabilities
> +          data (Dan Berrange), trying to re-create a pool should not destroy
> +          it (Dave Allan), endless loop in node device XML dump (Cole Robinson),
> +          Re-label shared and readonly images (Dan Berrange)
> +   - Improvements: create and destroy NPIV support (David Allan),
> +          networking in UML driver (Daniel Berrange), HAL driver restart
> +          thread safety (Daniel Berrange), capabilities and nodeinfo
> +          APIs for LXC (Daniel Berrange), iNUMA API for VBox (Daniel Berrange),
> +          dynamically search and use kvm-img qemu-img or qcow-create (Doug
> +          Goldstein), fix qemu and kvm version parsing (Mark McLoughlin),
> +          serial number for HAL storage (Dave Allan), improve error reporting
> +          for virConnectOpen URIs (Daniel Berrange), include OS driver name
> +          in device XML (Daniel Berrange), fix qemu command flags fetching
> +          (Cole Robinson), check that qemu support -drive format= (Cole
> +          Robinson), improve emulator detection (Cole Robinson), changes
> +          to config parser to accomodate VMX syntax (Matthias Bolte),
> +          update network schemas and driver for missing elements (Satoru SATOH),
> +          avoid changing file context if not needed (Tim Waugh),
> +          skip labelling if no src path (Cole Robinson), add arm emulation
> +          if qemu-system-arm is present (C.J. Adams-Collier)
> +   - Cleanups: daemon check logging env variables (Daniel Berrange),
> +          User Mode Linux start and stop cleanups (Daniel Berrange),
> +          share the NUMA api implementations (Daniel Berrange), storage
> +          module dependancies (Dave Allan), refactor storage XML parsing
> +          (Cole Robinson), big cleanup of logging code (Amy Griffis),
> +          superfluous % on format (Matthias Bolte), cleanups and updates
> +          on OpenNebula driver (Daniel Berrange and Abel Miguez Rodriguez)
> +
> +
>  0.6.4: May 29 2009:
>     - New features: new API virStorageVolCreateXMLFrom (Cole Robinson),
>            full VBox graphic capabilities (Pritesh Kothari), Interface config
> diff --git a/docs/Makefile.am b/docs/Makefile.am
> index 4bdb827..9ac2f6d 100644
> --- a/docs/Makefile.am
> +++ b/docs/Makefile.am
> @@ -127,8 +127,11 @@ libvirt-api.xml libvirt-refs.xml: apibuild.py \
>  	-(./apibuild.py)
> 
>  $(top_builddir)/NEWS: $(top_srcdir)/docs/news.xsl $(top_srcdir)/docs/news.html.in
> -	-@(if [ -x $(XSLTPROC) ] ; then \
> -	  $(XSLTPROC) --nonet $(top_srcdir)/docs/news.xsl $(top_srcdir)/docs/news.html.in > $(top_builddir)/NEWS ; fi );
> +	-@(if [ -x $(XSLTPROC) ] ; then				\
> +	  $(XSLTPROC) --nonet $(top_srcdir)/docs/news.xsl	\
> +	     $(top_srcdir)/docs/news.html.in			\
> +	   | perl -0777 -pe 's/\n\n+$$/\n/'			\
> +	   > $@-t && mv $@-t $@ ; fi );
> 
>  clean-local:
>  	rm -f *~ *.bak *.hierarchy *.signals *-unused.txt
> --
> 1.6.4.rc0.127.g81400

Fixes things here. ACK

Thanks,
Cole