[libvirt] PATCH: Fix non-raw storage volume cloning
Daniel P. Berrange
berrange at redhat.com
Fri Jul 17 12:08:11 UTC 2009
The recent storage patches broke cloning of non-raw volumes, due to a
small typo. THis was identified by the libvirt TCK storage tests!
Daniel
diff --git a/src/storage_backend.c b/src/storage_backend.c
index 1664804..67815d7 100644
--- a/src/storage_backend.c
+++ b/src/storage_backend.c
@@ -567,7 +567,7 @@ virStorageBackendGetBuildVolFromFunction(virConnectPtr conn,
(inputvol->type == VIR_STORAGE_VOL_FILE &&
inputvol->target.format != VIR_STORAGE_VOL_FILE_RAW)) {
- if ((tool_type = virStorageBackendFindFSImageTool(NULL)) != -1) {
+ if ((tool_type = virStorageBackendFindFSImageTool(NULL)) < 0) {
virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
"%s", _("creation of non-raw file images is "
"not supported without qemu-img."));
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list