[libvirt] [PATCH] rpm spec cleanup and split off client only requirements

[Daniel Veillard]

On Mon, Jul 20, 2009 at 05:46:37PM +0100, Daniel P. Berrange wrote:
> On Mon, Jul 20, 2009 at 06:34:26PM +0200, Daniel Veillard wrote:
> > So I moved in the client:
> >   - the shared library, I guess it's uncontroversial
> >   - the virsh/virt-xml-validate binaries, I guess it it doesn't block
> >     i386/x86_64 to be parallel installable that's fine
> >   - the man pages, obvious based on previous
> >   - the proxy when built, more controversial, it assumes that there
> >     is a service running locally so could be left on the main package
> 
> Yeah, I think this is best left in the main package. Even in proxy
> mode, you still really need libvirtd for the networking/storage
> APIs, so its minimal use to have it in the client. 
> 
> >   - sasl and policykit data, more controversial, I guess it's better
> >     to associate them with the client
> 
> The SASL config file is needed by both the client & server, so it
> has to go in the -client RPM as you've done.
> 
> PolicyKit is only used by libvirtd, so its best left in the main
> package
> 
> >   - the schemas to allow checking on the client
> 
> Makes sense.

  Okay I commited this and pushed, I first verified there was not
trouble having libvirt-client x86_64 and i586 installed in parallel.

> > +%if %{with_sasl}
> > +Requires: cyrus-sasl
> > +# Not technically required, but makes 'out-of-box' config
> > +# work correctly & doesn't have onerous dependencies
> > +Requires: cyrus-sasl-md5
> > +%endif
> 
> Latest IETF guidlines are moving to deprecate SASL md5 as insufficiently
> secure, so we should probably just drop this 'cyrus-sasl-md5' altogether,
> and update  our docs & default config to be kerberos.

  Okay, but IMHO this is mostly a documentation issue, once that is
fixed, then we can update the package,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/