[libvirt] [PATCH 3/5] disk geometry

Matthias Bolte matthias.bolte at googlemail.com
Fri Jun 26 18:23:02 UTC 2009


2009/6/25 Daniel P. Berrange <berrange at redhat.com>:
> On Wed, Jun 24, 2009 at 11:17:49AM +0200, Henrik Persson wrote:
>> Reads the disk geometry to be able to align disk partitions on cylinder boundries.
>> Msdos partition tables really like this stuff.

>> +    /* return the geometry of the disk and then exit */
>> +    if(cmd == DISK_GEOMETRY) {
>> +        printf("%d%c%d%c%d%c%",
>> +               dev->hw_geom.cylinders, '\0',
>> +               dev->hw_geom.heads, '\0',
>> +               dev->hw_geom.sectors, '\0');
>> +        return 0;
>> +    }
>> +

Is the trailing % intended in the format string? GCC warns about it,
breaking -Werror compilation.

Regards,
  Matthias




More information about the libvir-list mailing list