[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Don't disable all logging with --disable-debug

On Thu, Jun 25, 2009 at 04:13:28PM -0400, Amy Griffis wrote:
> This patch changes the automake conditional for debugging to
> disable only the debug output, not the entire logging module.
> Since the logging symbols are always visible now, I moved them to
> libvirt_private.syms and got rid of libvirt_debug.syms. I noticed
> that debugFlag wasn't being used anymore, so I removed that too.
> There was some code in __virExec where if you called with NULLs
> for childout and childerr, it would conditionally set the fds to
> either -1 or the /dev/null fd depending on ENABLE_DEBUG. I'm not
> sure why the difference, but it seemed safe to remove the entire
> conditional section since either setting is effectively treated
> the same way in the following code.

  All this makes a lot of sense, plus this is a serious cleanup, and
somehow disabling all output on --disable-debug was really a serious
bug (though I would hope everybody builds with debug enabled)

  Applied and commited,

   thanks a lot !


Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]