[libvirt] [PATCH] storage: fix disregarding specified owner/group permissions

[Ryota Ozaki]

Hi,

storage_conf.c always sets owner/group permissions as 0, even if non-0 values
are specified in XML. Because XPaths in DefParsePerms functions are wrong and
XPath functions using the XPaths fail, as a result the values obtained
by getpid()/getgid()
are used instead.

This patch fixes this and also unifies duplicated functions,
virStoragePoolDefParsePerms
and virStorageVolDefParsePerms, as a common function virStorageDefParsePerms
to fix the bug prettily.

One concern I have is the default value of mode permission in
virStorageDefParsePerms
is now 0700 but that in virStorageVolDefParsePerms was 0600. Is this
considerable
change?

Thanks,
  ozaki-r
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-storage-fix-disregarding-specified-owner-group-of-p.patch
Type: application/octet-stream
Size: 6077 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20090309/8f065f99/attachment-0001.obj>