[libvirt] [PATCH 0/2]: Cleanup driver initializers

Chris Lalancette clalance at redhat.com
Mon Mar 30 12:09:57 UTC 2009


All,
     This is a small series to cleanup the internal driver initializers.  The
drivers were using an annoying combination of C-99 style initialization and
old-style (C89?) initialization.  On top of that, the indentation on some of
these was wacky, making it even harder to read.  After some discussion with
DanB, we determined to go with the old-style initializers because it is sort of
a self-documenting TODO list.  The first patch converts the internal drivers to
all use this style of initialization, and fixes up a few wrong comments along
the way.  Note that this doesn't cleanup the storage or network initializers;
assuming this patch is acceptable, we can do those next.

The second patch rips out the internal "getURI" callbacks, since they were
never, ever used (and buggy to boot).  More details in the second patch.

-- 
Chris Lalancette




More information about the libvir-list mailing list