[libvirt] [PATCH 2/2]: Remove getURI internal driver call

Chris Lalancette clalance at redhat.com
Mon Mar 30 12:10:13 UTC 2009

This patch removes the internal getURI() driver callback.  It was *never*
overridden by any of the drivers, so it seems kind of pointless (I even checked
the "in-progress" VirtualBox, OpenNebula, and Power Hypervisor drivers).  In
addition, the code to actually use it in src/libvirt.c:virConnectGetURI() was
buggy; if a driver did decide to have their own callback, then their callback
would be called, and then immediately overwritten by the generic stuff.  This
wouldn't do what the driver expected, and would also probably leak memory.  Just
rip out this internal callback; if a future driver ever needs it, we can add it
back in.

Signed-off-by: Chris Lalancette <clalance at redhat.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libvirt-remove-getURI.patch
Type: text/x-patch
Size: 7074 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20090330/eacbe811/attachment-0001.bin>

More information about the libvir-list mailing list