[libvirt] PATCH: Add LSB init headers

[Daniel P. Berrange]

On Sun, May 03, 2009 at 05:30:23PM +0000, Frederik Himpe wrote:
> On Sun, 03 May 2009 18:26:24 +0200, Guido Günther wrote:
> 
> > On Sat, May 02, 2009 at 04:23:54PM +0000, Frederik Himpe wrote:
> >> The following patch is needed to make sure libvirt is not started too
> >> early in the boot sequence on Mandriva.
> >> 
> >> --- libvirt-0.6.1/qemud/libvirtd.init.in.orig	2009-03-05
> >> 19:34:05.000000000 +0100 +++ libvirt-0.6.1/qemud/libvirtd.init.in
> >> 2009-03-05 19:34:54.000000000 +0100 @@ -5,7 +5,11 @@
> >>  #
> >>  ### BEGIN INIT INFO
> >>  # Provides: libvirtd
> >> +# Required-Start: $network messagebus +# Should-Start: $named
> > What happens if you ommit it?
> > 
> > We have a
> > 
> > Should-Start: hal
> > 
> > in Debian since we do need it for device enumeration. Cheers,
> 
> IIRC if libvirtd was started before messagebus, libvirtd would not be 
> running correctly and virt-manager failed to connect to libvirt.

That is a bug. We use dbus to talk to avahi and to talk to HAL, but
both of those cases are supposed to fail gracefully if not available.
So if you start libvirtd without dbus running, it should still work.

That said, your original patch is still worthwhile, but would appreciate
someone tracking down the bug which prevents libvirtd working without
dbus too....

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|