[libvirt] [PATCH] Use correct error code in public VolCreateXML

Daniel P. Berrange berrange at redhat.com
Tue May 5 09:34:30 UTC 2009


On Mon, May 04, 2009 at 01:49:01PM -0400, Cole Robinson wrote:
> The attached patch fixes a use of an incorrect error code in libvirt.c
> VolCreateXML.

ACK

> commit 5e8ccec77f742a7b749c1ef6b51fb20cbe345d65
> Author: Cole Robinson <crobinso at redhat.com>
> Date:   Wed Apr 29 09:39:13 2009 -0400
> 
>     Use proper error code in virStorageVolCreateXML
> 
> diff --git a/src/libvirt.c b/src/libvirt.c
> index 90b4d90..ded18a7 100644
> --- a/src/libvirt.c
> +++ b/src/libvirt.c
> @@ -6740,7 +6740,7 @@ virStorageVolCreateXML(virStoragePoolPtr pool,
>      virResetLastError();
>  
>      if (!VIR_IS_STORAGE_POOL(pool)) {
> -        virLibConnError(NULL, VIR_ERR_INVALID_STORAGE_VOL, __FUNCTION__);
> +        virLibConnError(NULL, VIR_ERR_INVALID_STORAGE_POOL, __FUNCTION__);
>          return (NULL);
>      }
>  

> --
> Libvir-list mailing list
> Libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list


-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|




More information about the libvir-list mailing list