[libvirt] [PATCH] Fix the style of argument("cpumap") in op_pincpu()

[Tatsuro Enokura]

Hi Daniel,

Daniel Veillard wrote:
>> >> * xen-unstable
>> >> Set cpu affinity used by xenDaemonDomainPinCpu():
>> >> # set xenHypervisorPinVcpu() always return -1 for test
>> >>           | libvirt             | libvirt
>> >>           | current format      | new format
>> >>           +----------+----------+----------+----------
>> >>           | old xend | new xend | old xend | new xend
>> >> ---------+----------+----------+----------+----------
>> >> inactive |    (1)   |   (3)    |   (5)    |    (7)
>> >>    domain |    NG1   |   NG2    |   NG1    |    OK
>> >> ---------+----------+----------+----------+----------
>> >>    active |    (2)   |   (4)    |   (6)    |    (8)
>> >>    domain |    NG1   |   NG2    |   NG1    |    OK
>> >>
>> >> old xend: before xen-unstable changeset 19579
>> >> new xend: after  xen-unstable changeset 19580
>> >>
>> >> OK : virsh command end normaly and
>> >>       set cpu affinity.
>> >> NG1: virsh command end normaly, but
>> >>       can't set cpu affinity.
>> >> NG2: virsh command end with show error msg.
>> >>
>> >> Result (1),(2) is the same as result (5),(6).
> >
> >    Okay, but I'm still worrying.
> > The fact that we fail to detect the error NG1 is a bug, and that
> > bug should be fixed. Seems to me the change may just replace one error
> > by another one but in the end we should instead aim at fixing the NG1
> > problem with the old format, not substituing it with something else.
> >
> >    I would prefer if the patch did some checking about the current xend
> > version running, but unfortunately priv->xendConfigVersion won't be
> > precise enough.
> >
> >    Sorry I don't know how to handle this more correctly right now

I see.
priv->xendConfigVersion isn't appropriate for tracing the xend's
version. We should request to the xen community for new interface
of to get the xend's version.

On other hand,
the new xend and libvirt without the cpumap patch occur error(NG2).
Behavior of the old xend and libvirt with the cpumap patch is the same
behavior of libvirt without the cpumap patch.
Moreover, there is no work for libvirt of this issue any further at present.

I make the patch that added the foregoing content as TODO comment.

Signed-off-by: Tatsuro Enokura <fj2026af at aa.jp.fujitsu.com>

Thanks,
Tatsuro Enokura



-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: cpumap_take2.patch
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20090508/395e3b97/attachment-0001.ksh>