[libvirt] [PATCH] lxc: fix mknod file type

[Daniel P. Berrange]

On Thu, May 07, 2009 at 09:48:57AM +0900, Ryota Ozaki wrote:
> Hi,
> 
> On Thu, May 7, 2009 at 7:39 AM, Ryota Ozaki <ozaki.ryota at gmail.com> wrote:
> > Hi Daniel,
> >
> > On Wed, May 6, 2009 at 7:31 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> >> On Wed, May 06, 2009 at 04:01:32AM +0900, Ryota Ozaki wrote:
> >>> Hi,
> >>>
> >>> This patch fixes the 2nd argument of mknod syscall. The argument
> >>> should include a file type, i.e., S_IFCHR in this case, otherwise
> >>> created files will be regular files.
> >>
> >> Wierd. I guess no one has anything that uses this  becasue current
> >> code is clearly useless / broken.
> >
> > I think so unfortunately ;< Actually lxc does not work in my system
> > with cgroups enabled. lxc code probably remains some other bugs.
> 
> oops, I've found a bug in the previous patch. Please replace with
> the following patch.

Thanks, I've committed this patch now.

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|