[libvirt] [PATCH 3/3] networking API for hostonly networks in VirtualBox driver in libvirt

[Pritesh Kothari]

>   You really don't need to keep any data about the networking driver
> in libvirt(d) itself ?
>

as danpb explained it :)

> > +                        /* Currently support only one dhcp server per
> > network +                         * with contigious address space from
> > start to end +                         */
> > +                        if ((def->nranges == 1) &&
> > +                            (def->ranges[0].start) &&
> > +                            (def->ranges[0].end)) {

Fixed this to def->nranges >= 1 instead of above.

>   The patch is large but reuses the common routines for conversion
> to/from XML, a lot of the code is vbox internal structures peek/poke
> which are a bit hard to follow but this looks regular, the patch looks
> fine to me but feedback on previous points would be appreciated :-)

Reposting the patch as below with all the fix's mentioned on the list.

Regards,
Pritesh.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vbox_2009_05_06-3.patch
Type: text/x-patch
Size: 44578 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20090511/29ec5b23/attachment-0001.bin>