[libvirt] [PATCH 2/3] Support for vrdp/sdl/gui while dumping xml

Pritesh Kothari Pritesh.Kothari at Sun.COM
Mon May 11 13:56:43 UTC 2009


> > -                                def->graphics->data.rdp.autoport = 1;
> > +                                valueDisplayUtf8 = getenv("DISPLAY");
> > +                                valueDisplayFree = 0;
> >                              }
>
> Using getenv() here is not right, since that's running in the context of
> the app using libvirt. If there's no display available via virtualbox's
> API, then just leave this attribute blank when generating the XML.
>
>
> There's generally quite a few  uses of strdup() here without OOM
> checking

Fixed these two and reposting the patch.

Regards,
Pritesh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vbox_2009_05_07-2.patch
Type: text/x-patch
Size: 14264 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20090511/afa0e93d/attachment-0001.bin>


More information about the libvir-list mailing list