[libvirt] PATCH: Another attempt to fix vbox driver open
Daniel P. Berrange
berrange at redhat.com
Tue May 12 15:35:41 UTC 2009
On Mon, May 11, 2009 at 05:35:36PM +0200, Pritesh Kothari wrote:
> > - If the user gives a URI with a vbox:/// prefix, we should always
> > handle it, unless a 'server' is set when we leave it to the remote
> > driver
> > - If an invalid path is given we must give back a real error code
> > - If after deciding the URI is for us, any initialization fails
> > we must raise an error.
> > - If the vbox glue layer is missing, we should still raise errors
> > for requested URIs, so user knows their URI is correct.
> >
> > To do this, I've taken the approach of registering a dummy vbox driver
> > if the glue layer is missing. This just parses the URI and always returns
> > an error for any vbox:// URIs that would otherwise work
>
> ACK.
>
>
> works fine for 2.2.* as well as internal 2.5* development versions.
Thanks, I've committed this now
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list