[libvirt] [PATCH 6/7] Break out FS volume build routines to their own functions.

Cole Robinson crobinso at redhat.com
Tue May 12 20:37:19 UTC 2009


On 05/11/2009 08:58 AM, Daniel P. Berrange wrote:
> On Mon, May 04, 2009 at 01:43:01PM -0400, Cole Robinson wrote:
>> Improves readability, particularly wrt the pending CreateFromXML changes.
>> This will also help implementing File->Block volume creation in the future,
>> since some of this code will need to be moved to a backend agnostic file.
> 
> This is a nice idea - it was getting rather unwieldly as it grew.
> 
> ACK.
> 
> Daniel
> 

Since this is a mechanical change separate from the VolCreateXMLFrom
implementation, I've committed this.

Thanks,
Cole




More information about the libvir-list mailing list