[libvirt] [PATCH] networkDestroy: Report error if network is inactive

Cole Robinson crobinso at redhat.com
Thu May 28 17:16:24 UTC 2009


This follows the same convention as domain drivers.

Signed-off-by: Cole Robinson <crobinso at redhat.com>
---
 src/network_driver.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/src/network_driver.c b/src/network_driver.c
index 29652d1..3518e01 100644
--- a/src/network_driver.c
+++ b/src/network_driver.c
@@ -1238,6 +1238,12 @@ static int networkDestroy(virNetworkPtr net) {
         goto cleanup;
     }
 
+    if (!virNetworkIsActive(network)) {
+        networkReportError(net->conn, NULL, net, VIR_ERR_INTERNAL_ERROR,
+                           "%s", _("network is not active"));
+        goto cleanup;
+    }
+
     ret = networkShutdownNetworkDaemon(net->conn, driver, network);
     if (!network->persistent) {
         virNetworkRemoveInactive(&driver->networks,
-- 
1.6.0.6




More information about the libvir-list mailing list