[libvirt] [PATCH 2/2] Don't return fatal error in HAL driver init if HAL isn't running

[Daniel P. Berrange]

On Fri, Nov 13, 2009 at 10:14:22PM +0900, Ryota Ozaki wrote:
> On Fri, Nov 13, 2009 at 9:21 PM, Daniel P. Berrange <berrange at redhat.com> wrote:
> > The HAL driver returns a fatal error code in the case where HAL
> > is not running. This causes the entire libvirtd daemon to quit
> > which isn't desirable. Instead it should simply disable the HAL
> > driver
> 
> I'm not sure what happens on this defect though, I guess this may be
> a timing problem. I encountered this error during host and libvirtd bootup.
> However, once the host bootup has complete and then I starts libvirtd
> again, it succeeds.

Ah well for me, the issue arose when I did  'service haldaemon stop'
in order to test the new udev code in libvirt. Not sure of any timing
issues that would cause this, unless HAL is being started after libvirt
during system bootup

Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|