[libvirt] [PATCH v2] Disk- and Controller Hotplug

Wolfgang Mauerer wolfgang.mauerer at siemens.com
Tue Nov 24 13:15:58 UTC 2009


Daniel P. Berrange wrote:
> On Mon, Nov 23, 2009 at 02:15:06PM +0100, Wolfgang Mauerer wrote:
>> Daniel P. Berrange wrote:
>>> On Tue, Nov 17, 2009 at 12:53:31AM +0100, wolfgang.mauerer at siemens.com wrote:
>>>> this is the second revision of a patch series to improve disk
>>>> hotadd support for libvirt. It focuses on the qemu backend, but
>>>> is naturally designed to be compatible with other backends as
>>>> well. The objective is two-fold:
>>>> 1.) Split off controller from disk handling. This is done by
>>>>     introducing a new domain element <controller> that is used to
>>>>     describe disk controllers. Support for hotplugging such
>>>>     controllers is added.  Support to reference controllers by
>>>>     name is also included.
>>>> 2.) <disk>s can now be associated with a specific controller;
>>>>     this is done by means of a <controller> subelemnt for disks.
>>>> This patch addresses the questions that were raised during the
>>>> review of the initial submission, massages the code by fixing
>>>> some whitespace issues, gets static controller configurations to
>>>> work, and adds documentation. Notice that in contrast to the
>>>> first submission I did not include the patch that adds support
>>>> for disk- and controller hot_remove_. Since the qemu codebase is
>>>> still in bit of a flux wrt.  the necessary patches required for
>>>> this functionality, it will reappear some time later as a
>>>> separate submission.
>>> What libvirt version / GIT changeset  did you create these patches
>>> against ?  The current libvirt QEMU driver code in GIT is quite
>>> different, so the patches here don't apply for me as is.
>> sorry for the late reply, I could not access my eMail during
>> the last couple of days. Patches are on top of
>> 790f0b3057787bb64, I did not realise that this one was only
>> in the middle of qemu refactoring, not at the end :-(
>> Do you plan any more refactorings to the qemu base in the near
>> future, and if yes, are these already available somewhere? I'd
>> like to avoid another useless rebase...
> No, the monitor code for the QEMU driver is stable now. I'll only be adding
> extra functionality, not changing existing stuff, so it should be good to
> rebase against now.

okay, to avoid flooding the mailing list with nearly identical
patches, I've put the rebased versions into a repository at
git://git.kiszka.org/libvirt.git queue

Best regards,



The following changes since commit
  Daniel P. Berrange (1):

        Fix default disk type when parsing QEMU argv

are available in the git repository at:

  git://git.kiszka.org/libvirt.git queue

Wolfgang Mauerer (13):
      Fix help message
      Clarify documentation for private symbols
      Extend <disk> element with controller information
      Add new domain device: "controller"
      Add disk-based hotplugging for the qemu backend
      Drop qemudAttachPciDiskDevice
      Implement controller hotplugging
      Allow controller selection by ID
      Remove surprises in the semantics of disk-hotadd
      Factor out the method to get the PCI address of a controller for a
given disk
      Extract qemu monitor parts for controller hotplug
      Extract monitor parts from the qemu interaction for disk hotplug
      Update documentation: Controller

 daemon/libvirtd.c            |    2 +-
 docs/formatdomain.html.in    |   38 +++++
 docs/schemas/domain.rng      |  160 ++++++++++++++++------
 src/conf/domain_conf.c       |  314
 src/conf/domain_conf.h       |   62 ++++++++-
 src/libvirt_private.syms     |    7 +-
 src/qemu/qemu_driver.c       |  194 ++++++++++++++++++++++++--
 src/qemu/qemu_monitor_text.c |  199 ++++++++++++++++++++++++++
 src/qemu/qemu_monitor_text.h |    9 ++
 9 files changed, 925 insertions(+), 60 deletions(-)

More information about the libvir-list mailing list