[libvirt] [PATCH 1/2] add --crash support to "virsh dump"

Paolo Bonzini pbonzini at redhat.com
Mon Nov 30 14:44:13 UTC 2009


On 11/30/2009 03:27 PM, Daniel P. Berrange wrote:
> Shouldn't we be setting 'resume=0' here otherwise....
>
>> >        /* Since the monitor is always attached to a pty for libvirt, it
>> >           will support synchronous operations so we always get here after
>> >           the migration is complete.  */
>> >  -    if (resume&&  paused) {
>> >  +    else if (resume&&  paused) {
>> >            qemuDomainObjEnterMonitor(vm);
>> >            if (qemuMonitorStartCPUs(priv->mon, dom->conn)<  0) {
>> >                if (virGetLastError() == NULL)
>
> ....this will try to resume CPUs on a guest we just shutdown

That's why I changed "if" to "else if".

Paolo




More information about the libvir-list mailing list