[libvirt] [PATCH] in vbox driver, interface type bridge should really be type ethernet

[Pritesh Kothari]

Hi Florian,

On Wednesday 30 September 2009 20:08:36 Florian Vichot wrote:
> If I understand correctly, the "bridge" type for an interface means
> libvirt is in charge of creating a tun device and adding it to the
> specified bridge in the <source bridge=".."> attribute.This is not what
> the (badly named IHMO) "Bridged Networking" mode in vbox does: all it
> does is read and write its packets on the specified interface. Which is
> what a type "ethernet" interface does in my opinion. I joined a quick
> patch for that, Pritesh could you check it ?

If you check http://libvirt.org/formatdomain.html#elementsNICS then it is not 
much clear if the type bridged is more suitable or ethernet cause the bridged 
section says: "This assumes there is a bridge device on the host which has one 
or more of the hosts physical NICs enslaved" and which is what vbox is doing 
if i have got the interpretation right.

so frankly even thought the patch looks sane I am not sure about the 
terminology there and am confused as well. Maybe someone with greater 
knowledge in the networking area of libvirt should comment on it.

Regards,
Pritesh