[libvirt] [PATCH 1/7] Add virFileAbsPath() utility
Amy Griffis
amy.griffis at hp.com
Mon Oct 5 21:14:33 UTC 2009
Paolo Bonzini wrote: [Mon Oct 05 2009, 04:54:27AM EDT]
> On 10/04/2009 09:28 PM, Amy Griffis wrote:
> >Add a utility to ensure an absolute path for a potentially realtive path.
>
> Would it make sense for your usage to resolve symbolic links at the
> same time? If so, you can use the canonicalize-lgpl gnulib module,
> which portably provides the following function.
>
> /* Return a malloc'd string containing the canonical absolute name of
> the named file. If any file name component does not exist or is a
> symlink to a nonexistent file, return NULL. A canonical name does
> not contain any `.', `..' components nor any repeated file name
> separators ('/') or symlinks. */
> char *canonicalize_file_name (const char *);
In this case we don't need to resolve symlinks because the
following open() will handle them. I suppose it could be useful
to a future consumer, but I'm inclined to keep it as it is.
Amy
More information about the libvir-list
mailing list