[libvirt] [PATCH 03/10] tests: Break out duplicate schema verification functionality.
Matthias Bolte
matthias.bolte at googlemail.com
Fri Oct 16 19:18:57 UTC 2009
2009/10/12 Cole Robinson <crobinso at redhat.com>:
> All schema tests have identical functionality, so avoid the duplication.
>
> Signed-off-by: Cole Robinson <crobinso at redhat.com>
> ---
> tests/Makefile.am | 1 +
> tests/capabilityschematest | 34 ++++------------------------------
> tests/domainschematest | 33 ++++-----------------------------
> tests/interfaceschematest | 31 +++----------------------------
> tests/networkschematest | 30 +++---------------------------
> tests/nodedevschematest | 31 +++----------------------------
> tests/schematestutils.sh | 39 +++++++++++++++++++++++++++++++++++++++
> tests/storagepoolschematest | 31 +++----------------------------
> tests/storagevolschematest | 30 +++---------------------------
> 9 files changed, 63 insertions(+), 197 deletions(-)
> create mode 100644 tests/schematestutils.sh
Your patch adds some bashisms. This prevents make check from running
successfully on Debian/Ubuntu, because their default shell is dash and
not bash.
The attached patch removes this bashisms.
Matthias
-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove_bashisms.diff
Type: text/x-diff
Size: 2549 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20091016/bab4b0d3/attachment-0001.bin>
More information about the libvir-list
mailing list