[libvirt] [PATCH 2/4] Add a <graphics> type for SPICE protocol
Daniel P. Berrange
berrange at redhat.com
Sun Oct 25 22:54:19 UTC 2009
On Sun, Oct 25, 2009 at 05:15:26PM +0200, Dan Kenigsberg wrote:
> Just stumpbled on another issue:
>
> On Tue, Sep 29, 2009 at 04:43:50PM +0100, Daniel P. Berrange wrote:
> > @@ -366,6 +367,13 @@ struct _virDomainGraphicsDef {
> > char *display;
> > int fullscreen : 1;
> > } desktop;
> > + struct {
> > + int port;
> > + int tlsPort;
> > + char *listenAddr;
> > + char *keymap;
> > + char *passwd;
> > + } spice;
> > } data;
> > };
>
> just like vnc, spice needs autoport here (as well as in the schema).
>
> I wanted to ignore that, however, migration is impossibly unreliable
> without autoport=yes - the destination may have the port binded to
> something else.
Ok, i'll add that.
> BTW, and for the sake of the archives, <interface type='bridge'> with
> named <target dev= > is as problematic as specifying ports.
The <target> element should always be left out when defining XML so
that its all auto-assigned. In fact if you give a name of vnetXXX
then libvirt will totally ignore it
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list