[libvirt] [PATCH] libvirt-devel should only require libvirt-client

[Daniel P. Berrange]

On Wed, Oct 28, 2009 at 05:28:58PM +0000, Mark McLoughlin wrote:
> There's a long known issue where if you install libvirt in a guest,
> the default virtual network will conflict with the default virtual
> network in the host.
> 
> That's one of the reasons we have the libvirt-client RPM - it allows
> you to install the client library without having the host side
> installed.
> 
> Rich Jones points out that if you install libvirt-devel in a guest,
> then you get libvirtd installed and the network conflict:
> 
>   https://bugzilla.redhat.com/531200
> 
> libvirt-devel should only require libvirt-client - e.g. nothing in
> the devel package pertains to anything in the libvirt RPM. The Fedora
> packaging guidelines say:
> 
>   https://fedoraproject.org/wiki/Packaging/Guidelines#Devel_Packages
> 
>   Devel packages must require the base package using a fully versioned
>   dependency ...
> 
> But for all intents and purposes, libvirt-client is our base RPM.
> 
> * libvirt.spec.in: make libvirt-devel require libvirt-client
> ---
>  libvirt.spec.in |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/libvirt.spec.in b/libvirt.spec.in
> index 6cd0888..7e1550e 100644
> --- a/libvirt.spec.in
> +++ b/libvirt.spec.in
> @@ -341,7 +341,7 @@ virtualization capabilities of recent versions of Linux (and other OSes).
>  %package devel
>  Summary: Libraries, includes, etc. to compile with the libvirt library
>  Group: Development/Libraries
> -Requires: libvirt = %{version}-%{release}
> +Requires: libvirt-client = %{version}-%{release}
>  Requires: pkgconfig
>  %if %{with_xen}
>  Requires: xen-devel

ACK, long explanation for obviously needed fix :-)


Daniel
-- 
|: Red Hat, Engineering, London   -o-   http://people.redhat.com/berrange/ :|
|: http://libvirt.org  -o-  http://virt-manager.org  -o-  http://ovirt.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505  -o-  F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|