[libvirt] [PATCH 10/21] Don't let parent of daemon exit until basic initialization is done

[Guido Günther]

On Wed, Oct 28, 2009 at 06:52:49PM +0000, Daniel P. Berrange wrote:
> On Wed, Oct 28, 2009 at 03:22:38PM +0100, Guido G?nther wrote:
> > Hi Daniel,
> > On Fri, Oct 23, 2009 at 02:05:39PM +0100, Daniel P. Berrange wrote:
> > > The daemonizing code lets the parent exit almost immediately. This
> > > means that it may think it has successfully started even when
> > > important failures occur like not being able to acquire the PID
> > > file. It also means network sockets are not yet open.
> > With this patch applied to 0.7.2 I'm seeing:
> > 
> > # libvirtd -d
> > 15:20:22.457: error : main:2971 : Failed to fork as daemon: Success
> > 
> > about every second time I start the daemon. Any idea where this comes
> > from?
> 
> No, but that sounds bad to me - something I'm not expecting must be
> going on here. Definitely sounds like a race condition.
I should add that the daemon is running fine afterwards. It's just that
the parent believes it doesn't.
Cheers,
 -- Guido