[libvirt] Dead code vs. XXX comment: remove or not?

Jim Meyering jim at meyering.net
Thu Sep 3 16:28:13 UTC 2009


clang reported that this assignment to type is a dead store,
since type is never used after this point.

This is xm_internal.c, line 1074:

            /* XXX Forcing to pretend its a bridge */
            if (type == -1) {
                type = 1;
            }

Normally I'd just remove the whole if block, but the XXX comment
makes me think someone has plans for this code.

I'll wait for a second opinion.




More information about the libvir-list mailing list