[libvirt] [PATCH] Don't do virSetConnError when virDrvSupportsFeature is successful.
Daniel P. Berrange
berrange at redhat.com
Mon Sep 21 13:37:15 UTC 2009
On Mon, Sep 21, 2009 at 02:53:31PM +0200, Chris Lalancette wrote:
> Signed-off-by: Chris Lalancette <clalance at redhat.com>
> ---
> src/libvirt.c | 7 +++++--
> 1 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/src/libvirt.c b/src/libvirt.c
> index 4a11688..fa59dc7 100644
> --- a/src/libvirt.c
> +++ b/src/libvirt.c
> @@ -1349,8 +1349,11 @@ virDrvSupportsFeature (virConnectPtr conn, int feature)
> }
>
> ret = VIR_DRV_SUPPORTS_FEATURE (conn->driver, conn, feature);
> - /* Copy to connection error object for back compatability */
> - virSetConnError(conn);
> +
> + if (ret < 0)
> + /* Copy to connection error object for back compatability */
> + virSetConnError(conn);
> +
> return ret;
> }
>
> --
ACK
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
More information about the libvir-list
mailing list