[libvirt] [PATCH] Remove an unnecessary variable from remoteIOReadMessage().

Chris Lalancette clalance at redhat.com
Mon Sep 21 13:44:51 UTC 2009


Daniel P. Berrange wrote:
> On Mon, Sep 21, 2009 at 02:53:17PM +0200, Chris Lalancette wrote:
>> Signed-off-by: Chris Lalancette <clalance at redhat.com>
>> ---
>>  src/remote_internal.c |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/src/remote_internal.c b/src/remote_internal.c
>> index dd7b31e..b89d45d 100644
>> --- a/src/remote_internal.c
>> +++ b/src/remote_internal.c
>> @@ -6942,10 +6942,9 @@ remoteIOReadMessage(virConnectPtr conn, struct private_data *priv,
>>      if (priv->saslconn) {
>>          if (priv->saslDecoded == NULL) {
>>              char encoded[8192];
>> -            unsigned int encodedLen = sizeof(encoded);
>>              int ret, err;
>>              ret = remoteIOReadBuffer(conn, priv, in_open,
>> -                                     encoded, encodedLen);
>> +                                     encoded, sizeof(encoded));
>>              if (ret < 0)
>>                  return -1;
>>              if (ret == 0)
> 
> ACK

Thanks.  I'm ready to push these small fixes, but would it be more convenient
for me to wait until after you've pushed the big refactoring?  As long as you
are going to do that soon-ish, I can wait.

-- 
Chris Lalancette




More information about the libvir-list mailing list