[libvirt] [PATCH 26/27] Standardize debugging messages in QEMU monitor code
Mark McLoughlin
markmc at redhat.com
Mon Sep 28 13:23:10 UTC 2009
On Thu, 2009-09-24 at 16:00 +0100, Daniel P. Berrange wrote:
> * src/qemu/qemu_monitor_text.c: Always print command and reply
> in qemuMonitorCommandWithHandler. Print all args in each monitor
> command API & remove redundant relpy printing
> ---
> src/qemu/qemu_monitor_text.c | 82 ++++++++++++++++++++++++++++++-----------
> 1 files changed, 60 insertions(+), 22 deletions(-)
>
> diff --git a/src/qemu/qemu_monitor_text.c b/src/qemu/qemu_monitor_text.c
> index 2c41288..abb2c0a 100644
> --- a/src/qemu/qemu_monitor_text.c
> +++ b/src/qemu/qemu_monitor_text.c
...
> @@ -1408,6 +1440,8 @@ int qemuMonitorAddPCIHostDevice(const virDomainObjPtr vm,
> char *reply = NULL;
> int ret = -1;
>
> + DEBUG("vm=%p, pid=%d, id=%d, name=%s domain=%d bus=%d slot=%d function=%d", vm, vm->pid, vm->def->id, vm->def->name, hostDomain, hostBus, hostSlot, hostFunction);
A 165 character line, impressive! "Line break please Carol".
Looks fine otherwise, ACK
Cheers,
Mark.
More information about the libvir-list
mailing list