[libvirt] [PATCH 1/1] Initial POC of port profile id support
Dave Allan
dallan at redhat.com
Fri Apr 2 15:42:03 UTC 2010
On 03/31/2010 06:28 AM, Daniel P. Berrange wrote:
> On Tue, Mar 30, 2010 at 05:30:56PM -0400, David Allan wrote:
>> ---
>> docs/schemas/domain.rng | 8 ++++++++
>> src/conf/domain_conf.c | 12 ++++++++++++
>> src/conf/domain_conf.h | 1 +
>> src/libvirt_private.syms | 3 +++
>> src/qemu/qemu_conf.c | 12 ++++++++++++
>> src/util/macvtap.c | 13 +++++++++++++
>> src/util/macvtap.h | 4 ++++
>> 7 files changed, 53 insertions(+), 0 deletions(-)
>>
>> diff --git a/docs/schemas/domain.rng b/docs/schemas/domain.rng
>> index d804301..5917f60 100644
>> --- a/docs/schemas/domain.rng
>> +++ b/docs/schemas/domain.rng
>> @@ -794,6 +794,11 @@
>> <ref name="bridgeMode"/>
>> </attribute>
>> </optional>
>> +<optional>
>> +<attribute name="profileid">
>> +<ref name="profileID"/>
>> +</attribute>
>> +</optional>
>> <empty/>
>> </element>
>> <ref name="interface-options"/>
>> @@ -1647,6 +1652,9 @@
>> <param name="pattern">(vepa|bridge|private)</param>
>> </data>
>> </define>
>> +<define name="profileID">
>> +<data type="string"/>
>> +</define>
>> <define name="addrMAC">
>> <data type="string">
>> <param name="pattern">([a-fA-F0-9]{2}:){5}[a-fA-F0-9]{2}</param>
>
>
> I think this would be better off as a new element within interface, so
> that if we need more data associated with the profile we can provide
> it. eg perhaps something like
>
> <switchport profile='XYZ'/>
>
> Wouldn't this also be valid for the type=bridge networking mode, since
> that is connecting VMs to the LAN too.
Agreed with both; an updated patch is attached. I also added a test for
the new element.
Dave
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-POC-of-port-profile-id-support.patch
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100402/770d9711/attachment-0001.ksh>
More information about the libvir-list
mailing list