[libvirt] [PATCH] Optimization of the check for valid interface name

Eric Blake eblake at redhat.com
Fri Apr 2 18:45:37 UTC 2010


On 04/02/2010 12:11 PM, Stefan Berger wrote:
> The attached patch optimizes the validation of the name of an interface.
> 
> Signed-off-by: Stefan Berger
> 
> Index: libvirt-acl/src/conf/domain_conf.c
> ===================================================================
> --- libvirt-acl.orig/src/conf/domain_conf.c
> +++ libvirt-acl/src/conf/domain_conf.c
> @@ -1795,7 +1795,7 @@ cleanup:
>  
>  static bool
>  isValidIfname(const char *ifname) {
> -    return (strspn(ifname, VALID_IFNAME_CHARS) == strlen(ifname));
> +    return ifname[strspn(ifname, VALID_IFNAME_CHARS)] == 0;

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 323 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100402/cae9c301/attachment-0001.sig>


More information about the libvir-list mailing list