[libvirt] [PATCH] [3/4] Implement managed save operations for qemu driver

Chris Lalancette clalance at redhat.com
Fri Apr 2 20:51:15 UTC 2010

On 04/02/2010 04:26 PM, Eric Blake wrote:
>> -static int qemudDomainSave(virDomainPtr dom,
>> -                           const char *path)
>> +static int qemudDomainSaveFlag(virDomainPtr dom, const char *path,
>> +                               int compressed)
> Should that be bool compressed, since we are only using it as a binary?
>  Or are there plans to extend it in the future to allow choice between
> multiple acceptable compression algorithms, in which case it is better
> as an unsigned int?

No, it's definitely not a bool.  It's meant to take a number of different
arguments (like compressed-gzip, compressed-bzip2, etc).  So an unsigned
int seems better.

Chris Lalancette

More information about the libvir-list mailing list