[libvirt] [PATCH] nwfilter: Add filter schema for nwfilter XML, extend domain XML schema

Stefan Berger stefanb at us.ibm.com
Tue Apr 6 16:28:27 UTC 2010


Daniel Veillard <veillard at redhat.com> wrote on 04/06/2010 11:40:02 AM:

> Please respond to veillard

> 
>   Ah, okay, I understand now !
> 
> > I had a lot of problems finding a way to require a $ as first letter 
and I 
> > ended up having to use the [\\$]{1} construct. Also I could not find a 

> > switch for non-case-sensitive string comparison like other regexes 
have 
> > (?i) or \i for example... I suppose there is none.
> 
>   right. We are using XML Schemas datatype here, and the regexps are
> defined in this appendix
>   http://www.w3.org/TR/xmlschema-2/#regexs
> character $ has no special meaning in XML so doesn't need any escaping
>   http://www.w3.org/TR/xmlschema-2/#nt-SingleCharEsc
> 
>     <param name="pattern">$[a-zA-Z0-9_]+</param>
> 
> should just work fine I think, can you try ? If yes that's worth fixing
> before the push :-)

$ is the end of line indicator in regular expressions. I needs to be 
escaped, at the least.

I did push it already.

   Stefan

> 
> [...]
> > > I just find parameter-name/parameter-value a bit too generic names,
> > > if you could make them more specific to the task, like
> > >    filter-param-name / filter-param-value
> > > 
> > > but it's minor, and it's good to have updated schema and augmented
> > > testing
> > 
> > Ok, so I will rename those two to the names you suggest. Should I post 

> > again before pushing it to the repository?
> 
>   nahh, fine !
> 
> Daniel
> 
> -- 
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  
http://xmlsoft.org/
> daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
> http://veillard.com/ | virtualization library  http://libvirt.org/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100406/b6e55560/attachment-0001.htm>


More information about the libvir-list mailing list