[libvirt] [PATCH] Consolidate interface related functions in interface.c

Stefan Berger stefanb at us.ibm.com
Mon Apr 12 21:54:45 UTC 2010


Eric Blake <eblake at redhat.com> wrote on 04/12/2010 05:38:24 PM:

> 
> On 04/12/2010 02:21 PM, Stefan Berger wrote:
> > I am consolidating network interface related functions used in 
nwfilter
> > and macvtap code in utils/interface.c. All function names are prefixed
> > with 'Iface'. The following functions are now available through
> > interface.h:
> 
> I'm not a fan of initial caps.  Would it hurt to use the prefix 'iface'
> instead?

Of course not... changed that.

  Stefan

> 
> I don't want to ack until we get the naming settled, but other than
> that, the patch looked technically sound.
> 
> -- 
> Eric Blake   eblake at redhat.com    +1-801-349-2682
> Libvirt virtualization library http://libvirt.org
> 
> [attachment "signature.asc" deleted by Stefan Berger/Watson/IBM] 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100412/aa65d9d3/attachment-0001.htm>


More information about the libvir-list mailing list