[libvirt] [PATCHv2 2/2] remote: react to failures on wakeupFD

Eric Blake eblake at redhat.com
Thu Apr 15 17:41:42 UTC 2010

On 04/15/2010 11:25 AM, Jim Meyering wrote:
>>> This looks fine, but "errno ? errno : 0" is equivalent to just "errno".
>>> Which makes me think you'll want to separate the saferead-fails case
>>> (where errno is nonzero) from the
>>> saferead-returns-non-negative-<=-sizeof-ignore case (in which
>>> case virReportSystemError would print "Success" for errno=0).
>> Is this rewrite more what you had in mind? (No change to patch 1/2).
> Thanks.
> That looks better.  No more "Success" diagnostic upon error.

Thanks for the review; with that approval, I've pushed both patches.

Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 323 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100415/e55fe78c/attachment-0001.sig>

More information about the libvir-list mailing list