[libvirt] [PATCH] Mark in_open parameter of remoteAuthenticate as unused when it's unused
Eric Blake
eblake at redhat.com
Tue Apr 20 19:44:08 UTC 2010
On 04/20/2010 12:56 PM, Matthias Bolte wrote:
> Otherwise compiling with -Werror will fail.
> ---
>
>
> static int
> -remoteAuthenticate (virConnectPtr conn, struct private_data *priv, int in_open,
> +remoteAuthenticate (virConnectPtr conn, struct private_data *priv, int in_open
> +#if !HAVE_SASL && !HAVE_POLKIT
> + ATTRIBUTE_UNUSED
> +#endif
> + ,
> virConnectAuthPtr auth
> #if !HAVE_SASL && !HAVE_POLKIT
> ATTRIBUTE_UNUSED
I'd rather use mine instead as it occupies fewer lines and fewer
#ifdefs. Paolo Bonzini confirmed off-list that gcc treats
ATTRIBUTE_UNUSED as _maybe_ unused, not _must be_ unused.
https://www.redhat.com/archives/libvir-list/2010-April/msg00836.html
So I rebased mine on top of yours and pushed it.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100420/ec610815/attachment-0001.sig>
More information about the libvir-list
mailing list