[libvirt] [PATCH 09/10] Implement virsh qemu-monitor-command.

Eric Blake eblake at redhat.com
Wed Apr 21 19:47:38 UTC 2010


On 04/21/2010 10:01 AM, Chris Lalancette wrote:
> Signed-off-by: Chris Lalancette <clalance at redhat.com>
> ---
>  tools/Makefile.am |    1 +
>  tools/virsh.c     |   55 +++++++++++++++++++++++++++++++++++++++++++++++++++++

Nothing in tools/virsh.pod?  Hmm, we ought to modify docs/api_extension
to mention documenting new virsh commands (step 8/8).

> +    if (virDomainQemuMonitorCommand(dom, monitor_cmd, &result, 0) < 0)
> +        goto cleanup;
> +
> +    fprintf(stdout, "%s\n", result);

Isn't puts(result) more efficient, for the same end result?

To help keep docs in sync, I'll withhold an ack until seeing the .pod
updates in the respin :)

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100421/5767c6e7/attachment-0001.sig>


More information about the libvir-list mailing list