[libvirt] [PATCH] Fix handling of security driver restore failures in QEMU domain save

Laine Stump laine at laine.org
Sat Apr 24 04:48:19 UTC 2010

On 04/23/2010 06:49 AM, Daniel P. Berrange wrote:
> In cases where the security driver failed to restore a label after a
> guest has saved, we mistakenly jumped to the error cleanup paths.
> This is not good, because the operation has in fact completed and
> cannot be rolled back completely. Label restore is non-critical, so
> just log the problem instead. Also add a missing restore call in
> the error cleanup path

I have verified that this fixes the ability to save to /tmp, and does 
not hamper the ability to save to nfs shares (root-squashed or not). So 
ACK from a functional point of view as well.

More information about the libvir-list mailing list