[libvirt] [PATCH] Fix build on Ubuntu.

Eric Blake eblake at redhat.com
Wed Apr 28 20:59:51 UTC 2010


On 04/28/2010 02:27 PM, Chris Lalancette wrote:
> When building on Ubuntu with make -j3 (or more), it would always
> fail when trying to build virt-aa-helper.  I'm not an expert in
> automake by any means, but I think the entry for virt-aa-helper
> is mis-using LDADD; it shouldn't be putting direct paths to
> libvirt_conf.la and libvirt_util.la, but instead referencing those
> names.  With this patch in place, I'm able to successfully build
> on Ubuntu 9.04 with make -j3.

The patch is correct.  Automake can't see through the @top_srcdir@
indirection (for that matter, automake much prefers to use
$(top_srcdir), not @top_srcdir@); but does have magic in place to build
correctly with the simpler names even across VPATH trees.

ACK.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100428/16230629/attachment-0001.sig>


More information about the libvir-list mailing list