[libvirt] [PATCH] qemudDomainSaveFlag: remove dead store

Jim Meyering jim at meyering.net
Thu Apr 29 15:56:55 UTC 2010


Clang spotted a new (albeit harmless) dead store:

>From 0e37c524fb9c62d9b16443d6ff081c977963f4c5 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering at redhat.com>
Date: Thu, 29 Apr 2010 17:56:01 +0200
Subject: [PATCH] qemudDomainSaveFlag: remove dead store

* src/qemu/qemu_driver.c (qemudDomainSaveFlag): Remove dead store to "rc".
---
 src/qemu/qemu_driver.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 6ee5cc2..8c5d745 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -4818,7 +4818,7 @@ static int qemudDomainSaveFlag(virDomainPtr dom, const char *path,
             virReportSystemError(errno, _("unable to open %s"), path);
             goto endjob;
         }
-        if ((rc = qemudDomainSaveFileOpHook(fd, &hdata)) != 0) {
+        if (qemudDomainSaveFileOpHook(fd, &hdata) != 0) {
             close(fd);
             goto endjob;
         }
--
1.7.1.328.g9993c




More information about the libvir-list mailing list