[libvirt] [PATCH] nwfilter: RHEL 5 gcc fixes

Stefan Berger stefanb at us.ibm.com
Tue Apr 6 10:38:33 UTC 2010


Daniel Veillard <veillard at redhat.com> wrote on 04/06/2010 04:16:35 AM:


> Please respond to veillard
> 
> On Mon, Apr 05, 2010 at 05:23:41PM -0400, Stefan Berger wrote:
> > This patch fixes some compilation issues for the RHEL5 build. I am
> also removing the IPV6 constant where it appears in the wrong place.
> > 
> > Seems like a new bad thing to rely on the compiler to tell about 
> potentially uninitialized vars...
> 
>   hum, why ?

it seems the newer gcc don't tell about uninitialized variables?
> 
> > Signed-off-by; Stefan Berger <stefanb at us.ibm.com>
> > 
> > ---
> >  src/conf/nwfilter_conf.c |    7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> > 
> 
>   Patch looks fine to me,
> 
>   ACK,

Pushed.
   Stefan

> 
> Daniel
> 
> -- 
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  
http://xmlsoft.org/
> daniel at veillard.com  | Rpmfind RPM search engine http://rpmfind.net/
> http://veillard.com/ | virtualization library  http://libvirt.org/
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100406/b734a17b/attachment-0001.htm>


More information about the libvir-list mailing list