[libvirt] [PATCH] bridge: Add --dhcp-no-override option to dnsmasq

[Eric Blake]

On 08/11/2010 12:41 PM, Jiri Denemark wrote:
> --dhcp-no-override description from dnsmasq man page:
> 
>       Disable  re-use  of  the  DHCP servername and filename fields as
>       extra option space. If it can, dnsmasq moves the boot server and
>       filename  information  (from  dhcp-boot)  out of their dedicated
>       fields into DHCP options. This make extra space available in the
>       DHCP  packet  for options but can, rarely, confuse old or broken
>       clients. This flag forces "simple and safe" behaviour  to  avoid
>       problems in such a case.
> 
> It seems some virtual network card ROMs are this old/buggy so let's add
> --dhcp-no-override as a workaround for them. We don't use extra DHCP
> options so this should be safe.
> ---
>  src/network/bridge_driver.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)

Are we guaranteed that --dhcp-no-override is supported as far back as
the earliest version of dnsmasq that we claim to run with, or do we need
to add some --help parsing?

Conditional ACK if we are happy that all versions of dnsmasq that we
care about can support this flag.

-- 
Eric Blake   eblake at redhat.com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100811/761c5e31/attachment-0001.sig>