[libvirt] [PATCH] Add actions to virDomainLifecycle enum

[Jim Fehlig]

Eric Blake wrote:
>> +    <p>
>> +      on_crash supports these additional actions.
>>     
>
> Should we add a <since>0.8.4</since> tag here?
>   

Hmm, not sure.  None of the existing lifecycle documentation contains
<since> tags.

>> +++ b/src/conf/domain_conf.c
>> @@ -81,7 +81,9 @@ VIR_ENUM_IMPL(virDomainLifecycle, VIR_DOMAIN_LIFECYCLE_LAST,
>>                "destroy",
>>                "restart",
>>                "rename-restart",
>> -              "preserve")
>> +              "preserve",
>> +              "coredump-destroy",
>> +              "coredump-restart")
>>     
>
> Hmm.  These two new values are only valid for on_crash, but I don't see
> any code that rejects them for on_reboot or on_poweroff.  Do we need a
> separate enum here, or do we just need to add better checking to the
> remaining clients to detect enum values they can't support?
>   

Good point.  I moved these new options into a new enum and adjusted the
code accordingly.

V2 attached.

Thanks!
Jim

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-actions-to-virDomainLifecycle-enum.patch
Type: text/x-diff
Size: 14757 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100812/52791993/attachment-0001.bin>