[libvirt] [PATCH v3] nwfilter: extend nwfilter reload support

[Stefan Berger]

libvir-list-bounces at redhat.com wrote on 08/16/2010 12:09:48 PM:


> Please respond to "Daniel P. Berrange"
> 
> On Fri, Aug 13, 2010 at 04:36:32PM -0400, Stefan Berger wrote:
> > 
> > 
> > This time with a proper title.
> > 
> > v3:
> >     - Fixed an indentation problem
> > 
> >     - added bool parameter to function terminating the IP address 
> > learner threads to determine whether future threads may still run 
> > (needed in case of driver reload) or all must terminate (need in case 
of 
> > libvirtd termination)
> > 
> > v2:
> > 
> >     - Fixes to the nwfilter driver reload function that also needs a 
> > valid virConnectPtr.
> > 
> > In this patch I am extending and fixing the nwfilter module's reload 
> > support to stop all ongoing threads (for learning IP addresses of 
> > interfaces) and rebuild the filtering rules of all interfaces of all 
VMs 
> > when libvirt is started. Now libvirtd rebuilds the filters upon the 
> > SIGHUP signal and libvirtd restart.
> > 
> > About the patch: The nwfilter functions require a virConnectPtr. 
> > Therefore I am opening a connection in qemudStartup, which later on 
> > needs to be closed outside where the driver lock is held since 
otherwise 
> > it ends up in a deadlock due to virConnectClose() trying to lock the 
> > driver as well.
> > 
> > I have tested this now for a while with several machines running and 
> > needing the IP address learner thread(s). The rebuilding of the 
firewall 
> > rules seems to work fine following libvirtd restart or a SIGHUP. Also 
> > the termination of libvirtd worked fine.
> > 
> > 
> > Signed-off-by: Stefan Berger<stefanb at us.ibm.com>
> > 
[...]
> 
> This identation still seems to be wrong - so was the code being
> replaced. ACK aside from that
> 
> 
> Daniel


Pushed.
(This indentation issue must be related to something Thunderbird 3.1.1 
does to emails).

 Stefan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100816/f47a26ad/attachment-0001.htm>