[libvirt] PATCH 2/4: AppArmor updates

Jamie Strandboge jamie at canonical.com
Mon Aug 16 19:46:25 UTC 2010


On Mon, 2010-08-16 at 14:33 -0500, Jamie Strandboge wrote:
> On Mon, 2010-08-16 at 17:14 +0100, Daniel P. Berrange wrote:
> 
> > You can't blindly de-reference   data.file.path  - The 'file' struct
> > is inside a union and is only valid for certain types of character 
> > device VIR_DOMAIN_CHR_TYPE_PTY, TYPE_DEV, TYPE_FILE and TYPE_PIPE.
> > The existing code for serial devices is broken too & can crash due
> > to this
> 
> Hrmm. I always did it this. Maybe something changed and I missed it.
> Regardless, thanks for this feedback! :) Attached is an updated patch.

I didn't come out right. I meant I always did it in the wrong way, and
am glad to get this cleaned up.

-- 
Jamie Strandboge             | http://www.canonical.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20100816/79d96294/attachment-0001.sig>


More information about the libvir-list mailing list