[libvirt] [PATCH] qemu: Remove code duplication

Jiri Denemark jdenemar at redhat.com
Fri Aug 20 12:03:10 UTC 2010


We already filled the PCI address structure when we checked whether it's
free or not, so let's just use the structure here instead of filling it
again.
---
 src/qemu/qemu_conf.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/src/qemu/qemu_conf.c b/src/qemu/qemu_conf.c
index c7ed0a3..1c98447 100644
--- a/src/qemu/qemu_conf.c
+++ b/src/qemu/qemu_conf.c
@@ -2258,9 +2258,7 @@ int qemuDomainPCIAddressSetNextAddr(qemuDomainPCIAddressSetPtr addrs,
         }
 
         dev->type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_PCI;
-        dev->addr.pci.domain = 0;
-        dev->addr.pci.bus = 0;
-        dev->addr.pci.slot = i;
+        dev->addr.pci = maybe.addr.pci;
 
         addrs->nextslot = i + 1;
         if (QEMU_PCI_ADDRESS_LAST_SLOT < addrs->nextslot)
-- 
1.7.2




More information about the libvir-list mailing list